Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-script): Reach router import #36385

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix(gatsby-script): Reach router import #36385

merged 1 commit into from
Aug 15, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Aug 15, 2022 •
edited
Loading

Description

Import our Reach Router fork the same way we do in Gatsby Link. Originally used the other import because it appeared to not use the same module as Gatsby core otherwise.

Also adds Reach Router as a peer dependency.

Documentation

N/A

Related Issues

N/A

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 15, 2022
@tyhopp tyhopp marked this pull request as draft August 15, 2022 04:19
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 15, 2022
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label Aug 15, 2022
@LekoArts LekoArts marked this pull request as ready for review August 15, 2022 07:39
@LekoArts LekoArts merged commit 4c752d1 into master Aug 15, 2022
@LekoArts LekoArts deleted the fix-gatsby-script-router-import branch August 15, 2022 07:39
@gatsbybot gatsbybot mentioned this pull request Aug 16, 2022
Merged
marvinjude pushed a commit that referenced this pull request Aug 16, 2022
@tyhopp @marvinjude
fix(gatsby-script): Reach router import (#36385)
5f0b9ff 
(cherry picked from commit 4c752d1)
marvinjude pushed a commit that referenced this pull request Aug 16, 2022
@gatsbybot @tyhopp
fix(gatsby-script): Reach router import (#36385) (#36394)
1880491 
(cherry picked from commit 4c752d1)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
This was referenced Aug 16, 2022
Open
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Aug 16, 2022
Open
@Rutam21 Rutam21 mentioned this pull request Aug 16, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Aug 16, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Aug 16, 2022
Open
This was referenced Aug 16, 2022
Open
Open
Open
Open
Open
Open
This was referenced Dec 26, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
This was referenced Dec 26, 2022
Open
Open
Open
@monizb monizb mentioned this pull request Feb 16, 2023
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2023
Merged
@0xSebin 0xSebin mentioned this pull request Feb 28, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Apr 19, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 16, 2023
Open
@impactyogi impactyogi mentioned this pull request Nov 26, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 27, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 27, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 27, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 27, 2023
Open
Open
@monizb monizb mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 27, 2023
Open
Open
@wizbit wizbit mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
Open
Open
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyhopp @LekoArts